[PATCH] D22617: [ELF] - Linkerscript: add InputSectionDescription command to LS parser.

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 02:32:21 PDT 2016


evgeny777 added inline comments.

================
Comment at: ELF/LinkerScript.cpp:220
@@ -211,4 +219,3 @@
 bool LinkerScript<ELFT>::shouldKeep(InputSectionBase<ELFT> *S) {
-  for (StringRef Pat : Opt.KeptSections)
-    if (globMatch(Pat, S->getSectionName()))
-      return true;
+  for (const std::unique_ptr<BaseCommand> &Base : Opt.Commands)
+    if (auto *OutSec = dyn_cast<OutputSectionCommand>(Base.get()))
----------------
It looks like a slow-down compared with previous one, no?


https://reviews.llvm.org/D22617





More information about the llvm-commits mailing list