[PATCH] D19976: [ELF] - Prototype of possible linkerscript redesign.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 07:32:48 PDT 2016


ruiu added a comment.

It seems that this overlaps too much with Eugene's changes. There would be lots of conflicts. It's probably faster if you can split it up in a series of incremental patches and commit them one by one because while it is being review, the base code is being updated.


================
Comment at: ELF/LinkerScript.h:38
@@ +37,3 @@
+  OutSectionKind,
+  OutSectionEndKind,
+  InputSectionKind,
----------------
We shouldn't need an end marker. This struct represents a parsing result of a linker script and basically should form a parse tree. If you need an end marker, it means you are not creating a tree.


https://reviews.llvm.org/D19976





More information about the llvm-commits mailing list