[PATCH] D19976: [ELF] - Prototype of possible linkerscript redesign.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 08:09:20 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.h:38
@@ +37,3 @@
+  OutSectionKind,
+  OutSectionEndKind,
+  InputSectionKind,
----------------
ruiu wrote:
> We shouldn't need an end marker. This struct represents a parsing result of a linker script and basically should form a parse tree. If you need an end marker, it means you are not creating a tree.
Yes, I do not. 
CommandKind here is a just plain sequence of commands for parcing.


https://reviews.llvm.org/D19976





More information about the llvm-commits mailing list