[PATCH] D22288: ldd: Add GotEntrySize/GotPltEntrySize to ELF target

[Rui Ueyama via llvm-commits]

ruiu added a comment.

LGTM with nits.


================
Comment at: ELF/Target.h:86-87
@@ -85,2 +85,4 @@
   unsigned PltHeaderSize;
+  unsigned GotEntrySize;
+  unsigned GotPltEntrySize;
 
----------------
hjl.tools wrote:
> ruiu wrote:
> > Sort.
> What is the sorting order? Like this
> 
>   unsigned GotEntrySize;
>   unsigned GotPltEntrySize;
>   unsigned PltEntrySize;
>   unsigned PltHeaderSize;
Yeah. Since we are mixing uint32_t and unsigned, there's no single sort order, but at least for all members of the same type, I'd like to sort them alphabetically. So is it.


Repository:
  rL LLVM

http://reviews.llvm.org/D22288