[PATCH] D22288: ldd: Add GotEntrySize/GotPltEntrySize to ELF target

[H.J. Lu via llvm-commits]

On Tue, Jul 12, 2016 at 5:50 PM, Rui Ueyama <ruiu at google.com> wrote:
> ruiu added a comment.
>
> LGTM with nits.
>
>
> ================
> Comment at: ELF/Target.h:86-87
> @@ -85,2 +85,4 @@
>    unsigned PltHeaderSize;
> +  unsigned GotEntrySize;
> +  unsigned GotPltEntrySize;
>
> ----------------
> hjl.tools wrote:
>> ruiu wrote:
>> > Sort.
>> What is the sorting order? Like this
>>
>>   unsigned GotEntrySize;
>>   unsigned GotPltEntrySize;
>>   unsigned PltEntrySize;
>>   unsigned PltHeaderSize;
> Yeah. Since we are mixing uint32_t and unsigned, there's no single sort order, but at least for all members of the same type, I'd like to sort them alphabetically. So is it.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D22288
>

Here is the updated patch.  Please check it in for me.

Thanks.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldd-Add-GotEntrySize-GotPltEntrySize-to-ELF-target.patch
Type: text/x-patch
Size: 6704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160713/6075abb1/attachment.bin>