[PATCH] D22114: [InstCombine] extend vector select matching for non-splat constants

[Eli Friedman via llvm-commits]

eli.friedman added a comment.

I would lean towards making shufflevector canonical. It interacts better with existing transforms involving shuffles and vector insert/extract.  I can't think of any benefit to making the select form canonical.

It's good to be aware of how specific targets handle it, but it doesn't really matter that much given that we can just fix the target to pattern-match this kind of shufflevector.


http://reviews.llvm.org/D22114