[PATCH] D21785: [RFC]Add unittests to {ARM | AArch64}TargetParser

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 16:17:12 PDT 2016


rengolin added a comment.

Hi Jojo,

Thanks for the patch. I like how thorough were your tests, and it'll certainly cover a lot more than the current TripleTest. At some point, after we finish this, I think we should clean that one up, so that it stops redundant (and slow) tests.

Saleem (@compnerd), are you happy with the changes? I think we can discuss style in the class discussion (since it's going to change again, anyway), and just get all tools to use the parser for now.

cheers,
--renato


http://reviews.llvm.org/D21785





More information about the llvm-commits mailing list