[PATCH] D21460: [JumpThreading] Fix handling of aliasing metadata.

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 21:54:18 PDT 2016


eli.friedman added a comment.

It should be possible to merge it together... actually, that's probably a good idea considering the number of different versions we have of essentially the same code.  GVN has a version (and is missing checks in a couple places), Instcombine has two versions, EarlyCSE has a version (and is missing checks in a couple of places), BBVectorize has a version.  Basically, it's a mess.  We probably want a general "CSE-metadata" utility.  (There's probably also room for a "hoist-metadata" utility.)

That said, I'm not sure it makes sense to do that in this patch.


http://reviews.llvm.org/D21460





More information about the llvm-commits mailing list