[PATCH] D21288: [AArch64] Switch regression tests to test features not CPUs

[Renato Golin via llvm-commits]

rengolin added a comment.

Ok, some inline comment to make my point more explicit. :)

Otherwise, looks good. Thanks!


================
Comment at: test/CodeGen/AArch64/aarch64-a57-fp-load-balancing.ll:87
@@ -80,2 +86,3 @@
 ; CHECK-A53-DAG: str [[y]]
+; CHECK-GENERIC: stp [[x]], [[y]]
 
----------------
Here, A57 has BalanceFPOps and could check for CHECK-BALFP rather than spit in A57 up there and GENERIC down here.

================
Comment at: test/CodeGen/AArch64/merge-store.ll:11
@@ +10,3 @@
+
+; FAST: ldr s[[R0:[0-9]+]], {{\[}}[[R1:x[0-9]+]]{{\]}}, #4
+; FAST: ld1{{\.?s?}} { v[[R0]]{{\.?s?}} }[1], {{\[}}[[R1]]{{\]}}
----------------
These two sets of lines are identical because Cyclone has FeatureSlowMisaligned128Store, so the first RUN line could also check for CHECK-MISALIGNED instead of duplicate the CHECK lines or call it FAST.

================
Comment at: test/CodeGen/AArch64/misched-fusion.ll:15
@@ +14,3 @@
+; CHECK-CYCLONE: mov x1, x[[SUBRES]]
+; CHECK-GENERIC: mov w0, w[[ADDRES]]
+; CHECK-GENERIC: mov w1, w[[SUBRES]]
----------------
Duplicated, Cyclone has FeatureMacroOpFusion, call it CHECK-FUSION or something.


http://reviews.llvm.org/D21288