[PATCH] D21288: [AArch64] Switch regression tests to test features not CPUs

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 06:29:34 PDT 2016


sbaranga added a comment.

Hi Renato,

In http://reviews.llvm.org/D21288#463159, @rengolin wrote:

> So, if you have Cyclone specific as well as FeatureX in Cyclone:
>
>   ; RUN: ... cyclone ... FileCheck --check=FEATUREX --check=CYCLONE
>   ; RUN: ... +FeatureX . FileCheck --check=FEATUREX
>  
>   ; CHECK-CYCLONE: cyclone-specific things (Target->isCyclone())
>   ; CHECK-FEATUREX: Feature X things, including Cyclone
>   
>
> Makes sense?


It does, and I was trying to follow this already (see test/CodeGen/AArch64/misched-fusion.ll for example). Is there any place where you think the CHECK lines could be improved?

Cheers,
Silviu


http://reviews.llvm.org/D21288





More information about the llvm-commits mailing list