[PATCH] D21288: [AArch64] Switch regression tests to test features not CPUs

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 05:37:04 PDT 2016


rengolin added a comment.

Hi Silviu,

I was thinking more in the lines of using the same CHECK lines, to make sure they don't diverge?

So, if you have Cyclone specific as well as FeatureX in Cyclone:

  ; RUN: ... cyclone ... FileCheck --check=FEATUREX --check=CYCLONE
  ; RUN: ... +FeatureX . FileCheck --check=FEATUREX
  
  ; CHECK-CYCLONE: cyclone-specific things (Target->isCyclone())
  ; CHECK-FEATUREX: Feature X things, including Cyclone

Makes sense?

cheers,
--renato


http://reviews.llvm.org/D21288





More information about the llvm-commits mailing list