[PATCH] D21420: Properly handle short file names on the command line in Windows

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 13:55:15 PDT 2016

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM w/ `GetLongPathNameW > MAX_PATH` addressed.

Comment at: lib/Support/Windows/Process.inc:236-237
@@ +235,4 @@
+  DWORD Length = GetLongPathNameW(Arg, LongPath.data(), LongPath.capacity());
+  if (Length == 0 || Length > MAX_PATH)
+    return mapWindowsError(GetLastError());
+  LongPath.set_size(Length);
Is an error code set for the case where `Length > MAX_PATH`?  The MSDN docs seemed a little ambiguous.


More information about the llvm-commits mailing list