[PATCH] D21400: AMDGPU: Emit R_AMDGPU_ABS32_{HI, LO} for scratch buffer relocations

Konstantin Zhuravlyov via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 11:55:45 PDT 2016

kzhuravl added inline comments.

Comment at: include/llvm/Object/RelocVisitor.h:144-146
@@ +143,5 @@
+        switch (RelocType) {
+        case llvm::ELF::R_AMDGPU_ABS32_LO:
+        case llvm::ELF::R_AMDGPU_ABS32_HI:
+          return visitELF_AMDGPU_32(R, Value);
+        default:
tstellarAMD wrote:
> kzhuravl wrote:
> > This processes HI relocations as LO. Should not LO and HI be processed differently, or am I missing something?
> The RelocVisitor seems to only be used in DwarfContext.cpp.  It's not clear me what it's even supposed to do with absolute relocations.  Is this code even necessary?
I think at this point we will only need to handle R_AMDGPU_ABS32 in RelocVisitor, since we are going to use it for dwarf relocs


More information about the llvm-commits mailing list