[PATCH] D21432: [ARM] Do not test for CPUs, use SubtargetFeatures (Part 1). NFC

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 11:45:01 PDT 2016

MatzeB added a comment.

Looks mostly good to me, but:

Comment at: lib/Target/ARM/ARMSubtarget.h:221-237
@@ -220,1 +220,19 @@
+  /// If true, if conversion may decide to leave some instructions unpredicated.
+  bool IsProfitableToUnpredicate;
+  /// If true, VMOV will be favored over VGETLNi32.
+  bool HasSlowVGETLNi32;
+  /// If true, VMOV will be favored over VDUP.
+  bool HasSlowVDUP32;
+  /// If true, VMOVSR will be favored over VMOVDRR.
+  bool PreferVMOVSR;
+  /// If true, ISHST barriers will be used for Release semantics.
+  bool PreferISHST;
+  /// If true, VMOVRS, VMOVSR and VMOVS will be converted from VFP to NEON.
+  bool UseNEONForFPMovs;
This needs to be initialized, you may want to do a similar commit as I did in r271057 and use member initializers throughout the Subtarget class.


More information about the llvm-commits mailing list