[PATCH] D21432: [ARM] Do not test for CPUs, use SubtargetFeatures (Part 1). NFC

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.

================
Comment at: lib/Target/ARM/ARM.td:111
@@ +110,3 @@
+// during if conversion.
+def FeatureProfUnpredicate : SubtargetFeature<"prof-unpr",
+                                              "IsProfitableToUnpredicate",
----------------
I think that it may be easier to actually have this be inverted and have a "cheap predicates" feature which would normally be false.

================
Comment at: lib/Target/ARM/ARM.td:127
@@ +126,3 @@
+// for scalar FP, as this allows more effective execution domain optimization.
+def FeaturePreferVMOVSR : SubtargetFeature<"pref-vmovsr", "PreferVMOVSR",
+                                           "true", "Prefer VMOVSR">;
----------------
Why not spell out prefer?  I don't think that the two extra characters are that bad here.

================
Comment at: lib/Target/ARM/ARM.td:132
@@ +131,3 @@
+// than ISH
+def FeaturePrefISHSTBarrier : SubtargetFeature<"pref-ishst", "PreferISHST",
+                                           "true", "Prefer ISHST barriers">;
----------------
Similar.

================
Comment at: lib/Target/ARM/ARM.td:137
@@ +136,3 @@
+// VFP to NEON.
+def FeatureNEONForFPMovs : SubtargetFeature<"neon-fpmovs", "UseNEONForFPMovs",
+                              "true", "Convert VMOVSR, VMOVRS, VMOVS to NEON">;
----------------
`FeatureNEONFPMoves` perhaps?

================
Comment at: lib/Target/ARM/ARMInstrInfo.td:330
@@ -336,1 +329,3 @@
+def UseVMOVSR : Predicate<"Subtarget->preferVMOVSR() || !Subtarget->useNEONForSinglePrecisionFP()">;
+def DontUseVMOVSR : Predicate<"!Subtarget->preferVMOVSR() && Subtarget->useNEONForSinglePrecisionFP()">;
 
----------------
Wrap these two lines?  They seem beyond 80 characters.


http://reviews.llvm.org/D21432