[PATCH] D21052: IR: Allow metadata attachments on declarations, and fix lazy loaded metadata issue with globals.

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 13:57:55 PDT 2016

aprantl added a comment.

The code itself looks fine to me.

Comment at: lib/Bitcode/Writer/ValueEnumerator.cpp:351
@@ -350,2 +350,3 @@
     for (const auto &I : MDs)
-      EnumerateMetadata(&GV, I.second);
+      // FIXME: Pass GV to EnumerateMetadata and arrange for the bitcode writer
+      // to write metadata to the global variable's own metadata block.
I'm just curious: Is this being addressed in one of the follow-up reviews? If not, can you please file a PR about it?


More information about the llvm-commits mailing list