[PATCH] D21052: IR: Allow metadata attachments on declarations, and fix lazy loaded metadata issue with globals.
Duncan P. N. Exon Smith via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 14 13:36:13 PDT 2016
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Sorry for the delay. At a high-level, here are my concerns (which you may have already addressed: I haven't looked at the patch yet):
- !dbg attachments on declarations should be disallowed (I suggest the verifier?).
- PGO attachments on declarations should probably also be disallowed?
- Along the same lines, I think having two !dbg (or PGO) attachments on the same function should be disallowed. I can imagine loosening this restriction in the future (with lots more work) but I think right now it would cause a bug.
- Lazy-loading needs to be fast.
I won't have time to review this in detail for at least a few days, but I'm also happy to defer to others.
More information about the llvm-commits