[PATCH] D21293: [FileCheck] Add --check-prefixes as a shorthand for multiple --check-prefix options.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 07:04:37 PDT 2016

dsanders added a comment.

> Wow. I am blown away by the sophisticated implementation. :-)

I didn't believe it could be that simple.

> So, the MC/Mips test ought to be committed separately (as part of http://reviews.llvm.org/D21292 clearly).

Yep, it's in here because of the order of the patches in my current series but it looks like this will be committed first so I'll fold that part into http://reviews.llvm.org/D21292.

> Also I think you went a bit overboard with the FileCheck tests, no need to replicate *all* the multi-prefix runs. I'd think a couple representative tests would be enough, maybe just check-multiple-prefixes-mixed.txt and multiple-missing-prefixes.txt.

Makes sense. In addition to the two you mention, I'll also keep the two *-no-match*.txt tests. Most of the tests can falsely pass if only one prefix takes effect so the *-no-match*.txt tests are needed to make sure all the prefixes are being processed.

> With that, LGTM.



More information about the llvm-commits mailing list