[PATCH] D21293: [FileCheck] Add --check-prefixes as a shorthand for multiple --check-prefix options.

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 10:23:57 PDT 2016

probinson added a subscriber: probinson.
probinson added a comment.

Wow.  I am blown away by the sophisticated implementation.  :-)

So, the MC/Mips test ought to be committed separately (as part of http://reviews.llvm.org/D21292 clearly).
Also I think you went a bit overboard with the FileCheck tests, no need to replicate *all* the multi-prefix runs.  I'd think a couple representative tests would be enough, maybe just check-multiple-prefixes-mixed.txt and multiple-missing-prefixes.txt.

With that, LGTM.


More information about the llvm-commits mailing list