[PATCH] D20993: Add support for collating profiles for use with code coverage
Vedant Kumar via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 13 15:42:36 PDT 2016
vsk added a comment.
Thanks for the feedback and reviews. I'm planning on committing after double-checking that this doesn't break any of our PGO bots.
Comment at: utils/prepare-code-coverage-artifact.py:20
@@ +19,3 @@
+ raw_profiles = glob.glob(os.path.join(profile_data_dir, '*.profraw'))
+ manifest_path = os.path.join(profile_data_dir, 'profiles.manifest')
+ profdata_path = os.path.join(profile_data_dir, 'Coverage.profdata')
> vsk wrote:
> > davidxl wrote:
> > > is profiles.manifest file needed here? does it simplify the process?
> > It's a bit of future-proofing. It was needed with the previous patch because of the sheer number of raw profiles. Now, it helps avoid failures during the `check_call` step due to too many arguments.
> `%m` only supports up to 9, which should be fine even on windows. It would make things slightly simpler to pass directly on the command line.
Fair point, though that does get multiplied by the number of distinct binaries invoked.
More information about the llvm-commits