[PATCH] D20993: Add support for collating profiles for use with code coverage
Sean Silva via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 13 15:37:58 PDT 2016
silvas accepted this revision.
silvas added a reviewer: silvas.
silvas added a comment.
Thanks for converting the script to python!
One advisory comment on the script (not a big deal), but this LGTM.
Comment at: utils/prepare-code-coverage-artifact.py:20
@@ +19,3 @@
+ raw_profiles = glob.glob(os.path.join(profile_data_dir, '*.profraw'))
+ manifest_path = os.path.join(profile_data_dir, 'profiles.manifest')
+ profdata_path = os.path.join(profile_data_dir, 'Coverage.profdata')
> davidxl wrote:
> > is profiles.manifest file needed here? does it simplify the process?
> It's a bit of future-proofing. It was needed with the previous patch because of the sheer number of raw profiles. Now, it helps avoid failures during the `check_call` step due to too many arguments.
`%m` only supports up to 9, which should be fine even on windows. It would make things slightly simpler to pass directly on the command line.
More information about the llvm-commits