[PATCH] D20762: AArch64: Do not test for CPUs, use SubtargetFeatures

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 08:25:35 PDT 2016


rengolin added a comment.

In http://reviews.llvm.org/D20762#453405, @evandro wrote:

> Somewhat an RFC, but perhaps `ARMProcFamilyEnum` values should be defined as masks so that, when checking for multiple families,


Hi Evandro,

That'd be a good idea if we were trying to encourage people to use them, but we're not.

They're just there because not all could be easily moved into features, but they should, eventually. And all new such decisions should be made into features, so we should also avoid usage of that function like the plague. :)

cheers,
--renato


Repository:
  rL LLVM

http://reviews.llvm.org/D20762





More information about the llvm-commits mailing list