[PATCH] D20762: AArch64: Do not test for CPUs, use SubtargetFeatures

Evandro Menezes via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 08:20:12 PDT 2016


evandro added a comment.

Somewhat an RFC, but perhaps `ARMProcFamilyEnum` values should be defined as masks so that, when checking for multiple families, one can write:
`Subtarget.getProcFamily() & (AArch64Subtarget::CortexA57 | AArch64Subtarget::ExynosM1)`

Instead of:
`Subtarget.getProcFamily() == AArch64Subtarget::CortexA57 || Subtarget.getProcFamily() == AArch64Subtarget::ExynosM1`

Thoughts?


Repository:
  rL LLVM

http://reviews.llvm.org/D20762





More information about the llvm-commits mailing list