[PATCH] D21061: [ARM] Remove exit-on-error flag from test (PR27765)

[Diana Picus via llvm-commits]

rovka added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:452
@@ -451,1 +451,3 @@
                                         "scalar-to-vector conversion failed");
+      Val = DAG.getNode(ISD::BITCAST, DL, PartVT, Val);
+    }
----------------
rengolin wrote:
> I take it that this transformation is harmless, since the compilation is going to fail anyway.
> 
> But I'm worried that this could trigger unrelated errors down the pipe until the last error is reported and the program exits, and confuse the user.
Not taking this lightly, but we're not seeing any other errors now, and I'm not sure how you could recover in a way that would guarantee you won't see any bogus errors ever (while still reporting all the useful ones). I think it should be pretty safe to have a bitcast between two values that have the same number of bits (assertion just above, at line 445).

I'm open to other suggestions though :)


http://reviews.llvm.org/D21061