[PATCH] D21061: [ARM] Remove exit-on-error flag from test (PR27765)

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 04:47:16 PDT 2016


rengolin added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:452
@@ -451,1 +451,3 @@
                                         "scalar-to-vector conversion failed");
+      Val = DAG.getNode(ISD::BITCAST, DL, PartVT, Val);
+    }
----------------
I take it that this transformation is harmless, since the compilation is going to fail anyway.

But I'm worried that this could trigger unrelated errors down the pipe until the last error is reported and the program exits, and confuse the user.


http://reviews.llvm.org/D21061





More information about the llvm-commits mailing list