[PATCH] D20741: [LibFuzzer] Fix weak linking issues building tests under OSX.

[Anna Zaks via llvm-commits]

zaks.anna added a comment.

In http://reviews.llvm.org/D20741#445224, @mehdi_amini wrote:

> In http://reviews.llvm.org/D20741#445216, @kcc wrote:
>
> > > I think it's probably fine for now but I don't think the goal of having a really simple compilation command line for LibFuzzer is sustainable long term
> >
> >
> > I am not convinced. Worked well so far.
>
>
> Well actually I'm not sure it did work that well: nobody could follow the doc and build on OSX.


LibFuzzer is not supported on OS X, so there was no expectation that following the instructions would work.

Simple user interface (command line and API) should be the highest priority here. I believe using dlsym on the Mac and weak linking on Linux is the best option. (Sanitizers implement platform specific behavior as well.)


http://reviews.llvm.org/D20741