[PATCH] D20741: [LibFuzzer] Fix weak linking issues building tests under OSX.

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In http://reviews.llvm.org/D20741#445249, @zaks.anna wrote:

> In http://reviews.llvm.org/D20741#445224, @mehdi_amini wrote:
>
> > In http://reviews.llvm.org/D20741#445216, @kcc wrote:
> >
> > > > I think it's probably fine for now but I don't think the goal of having a really simple compilation command line for LibFuzzer is sustainable long term
> > >
> > >
> > > I am not convinced. Worked well so far.
> >
> >
> > Well actually I'm not sure it did work that well: nobody could follow the doc and build on OSX.
>
>
> LibFuzzer is not supported on OS X, so there was no expectation that following the instructions would work.


The doc only mentions Windows as unsupported because "The sanitizer coverage support does not work on Windows either as of 01/2015" (see http://llvm.org/pre-releases/3.8.0/rc2/docs/LibFuzzer.html#q-what-about-windows-then-the-fuzzer-contains-code-that-does-not-build-on-windows).
So it seem to me to be a reasonable expectation to have it build on most platform that can build LLVM.


http://reviews.llvm.org/D20741