[PATCH] D20752: [MC] Support symbolic expressions in assembly directives

[Rafael Espíndola via llvm-commits]

Have you tried building with asan/ubsan?

Cheers,
Rafael


On 27 May 2016 at 17:38, Petr Hosek <phosek at chromium.org> wrote:
> phosek added a comment.
>
> This is a reland of http://reviews.llvm.org/D20656, I believe the test failure was caused by the `truncateToSize` invocation at MCAsmStreamer.cpp:844. The second argument is number of bytes and not number of bits to truncate to, so the original version which contained `truncateToSize(Expr, 32)` was obviously wrong.
>
> Unfortunately, I haven't managed to replicate the test failure on my machines (both x86-64 Linux and OS X)—even the original version passed `check-all` locally but failed on bots—so I don't know if this was the only issue but I haven't spotted anything obviously wrong after going through the entire patch.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20752
>
>
>