[PATCH] D20752: [MC] Support symbolic expressions in assembly directives

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 14:38:57 PDT 2016

phosek added a comment.

This is a reland of http://reviews.llvm.org/D20656, I believe the test failure was caused by the `truncateToSize` invocation at MCAsmStreamer.cpp:844. The second argument is number of bytes and not number of bits to truncate to, so the original version which contained `truncateToSize(Expr, 32)` was obviously wrong.

Unfortunately, I haven't managed to replicate the test failure on my machines (both x86-64 Linux and OS X)—even the original version passed `check-all` locally but failed on bots—so I don't know if this was the only issue but I haven't spotted anything obviously wrong after going through the entire patch.



More information about the llvm-commits mailing list