[PATCH] D18972: [AMDGPU] Add basic relocation support (currently used for dwarf only)

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 10:13:59 PDT 2016


Please leave the high one out of this patch.

It looks like the low one is actually just a 32 bit reloc. If not, add a
test case that shows the difference.
On May 27, 2016 1:10 PM, "Tom Stellard" <thomas.stellard at amd.com> wrote:

> tstellarAMD added a comment.
>
> In http://reviews.llvm.org/D18972#442403, @rafael wrote:
>
> > If this is just for dwarf, why do you need high and lo relocations?
> >
> > On x86_64 we use 32 and 64 relocations, but they apply to 32 and 64 bit
> >  values.
>
>
>
>
> In http://reviews.llvm.org/D18972#442405, @rafael wrote:
>
> > In fact, you have no .s that produces a high relocation.
>
>
> This  patch adds all the relocation definitions, but only uses the ones
> required for dwarf.  I'm working on patches to add support for relocations
> of global variables, which use the high relocations.
>
>
> http://reviews.llvm.org/D18972
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160527/53dc0259/attachment.html>


More information about the llvm-commits mailing list