[PATCH] D20598: [X86] Detect SAD patterns and emit psadbw instructions on X86 redux

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 16:01:26 PDT 2016


mkuper updated this revision to Diff 58711.
mkuper added a comment.

Got rid of NumConcat.

Regarding the shuffle - I don't see a good way to get rid of it locally. If you have an idea on how to do that, I'll be happy to hear it.
It can probably be cleaned up with a DAGCombine that recognizes the shuffle we get from the extract is a nop (because the only lanes it shuffles around are zero). Are you ok with leaving a fixme, and following up on that separately if we think it's worthwhile?


http://reviews.llvm.org/D20598

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/sad.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20598.58711.patch
Type: text/x-patch
Size: 7194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160526/afa7e855/attachment.bin>


More information about the llvm-commits mailing list