[PATCH] D20649: [X86] Add a pattern that uses GR16_ABCD rather than GR32_ABCD to avoid falsely marking whole 32 bit register as live.

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 08:23:17 PDT 2016

spatel added reviewers: MatzeB, mbodart, qcolombet.
spatel added a comment.

[cc'ing Matthias, Mitch, Quentin ; a related test suggestion was made in http://reviews.llvm.org/D20456]

The code change itself looks fine to me, but I wonder if there's a preference for the test case to use "-stop-after" instead (similar to how MIR tests are written):

; RUN: llc -march=x86 -stop-after=expand-isel-pseudos <%s 2>&1 | FileCheck %s

And then either CHECK for the exact expected sequence of machine instructions or CHECK-NOT the instructions that are generated without the patch:

  %5 = INSERT_SUBREG %6, %0, 3
  %7 = COPY %5


More information about the llvm-commits mailing list