[PATCH] D20335: [AMDGPU] Emit debugger prologue and emit the rest of the debugger fields in the kernel code header

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.h:80-86
@@ -77,1 +79,9 @@
 
+    // Fixed SGPR number used to hold wave scratch offset for entire kernel
+    // execution, or uint16_t(-1) if the register is not used or not known.
+    uint16_t DebuggerWavefrontPrivateSegmentOffsetSGPR;
+    // Fixed SGPR number of the first 4 SGPRs used to hold scratch V# for entire
+    // kernel execution, or uint16_t(-1) if the register is not used or not
+    // known.
+    uint16_t DebuggerPrivateSegmentBufferSGPR;
+
----------------
Why are these using the SGPR number and special invalid register instead of the phys reg ID and NoReg?

================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:690
@@ +689,3 @@
+      // Create fixed stack object for work group ID.
+      ObjectIdx = MF.getFrameInfo()->CreateFixedObject(4, i * 4, true);
+      Info->setDebuggerWorkGroupIDStackObjectIndex(i, ObjectIdx);
----------------
Why not create a single object and use offsets into it?


http://reviews.llvm.org/D20335