[PATCH] D20335: [AMDGPU] Emit debugger prologue and emit the rest of the debugger fields in the kernel code header

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 09:20:58 PDT 2016

arsenm added inline comments.

Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:93-103
@@ -90,13 +92,13 @@
   if (F->hasFnAttribute("amdgpu-work-group-id-y"))
     WorkGroupIDY = true;
   if (F->hasFnAttribute("amdgpu-work-group-id-z"))
     WorkGroupIDZ = true;
   if (F->hasFnAttribute("amdgpu-work-item-id-y"))
     WorkItemIDY = true;
   if (F->hasFnAttribute("amdgpu-work-item-id-z"))
     WorkItemIDZ = true;
I don't agree. I don't think it makes sense to add a attribute based on a subtarget feature. If the feature is attached to the subtarget already, this is just adding more clutter to the attribute list. We should just implement the per-function subtarget stuff since a subtarget is basically a collection of subtarget features.


More information about the llvm-commits mailing list