[PATCH] D20331: [llvm-mc] - Teach llvm-mc to generate compressed debug sections in zlib style.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 07:42:22 PDT 2016


davide added inline comments.

================
Comment at: lib/MC/ELFObjectWriter.cpp:576
@@ -575,4 +575,3 @@
   auto &Sec = cast<MCSectionELF>(Sym->getSection());
-  unsigned Flags = Sec.getFlags();
-  if (Flags & ELF::SHF_MERGE) {
+  if (Sec.Flags & ELF::SHF_MERGE) {
     if (C != 0)
----------------
You can change that separately, if you really like. It's unrelated, and makes the patch slightly less readable.

================
Comment at: lib/MC/MCSectionELF.cpp:162
@@ -161,5 +161,3 @@
 
-bool MCSectionELF::UseCodeAlign() const {
-  return getFlags() & ELF::SHF_EXECINSTR;
-}
+bool MCSectionELF::UseCodeAlign() const { return Flags & ELF::SHF_EXECINSTR; }
 
----------------
Unrelated.


http://reviews.llvm.org/D20331





More information about the llvm-commits mailing list