[llvm] r269292 - [AArch64] Remove command-line option use for testing.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 06:27:25 PDT 2016


Author: mcrosier
Date: Thu May 12 08:27:24 2016
New Revision: 269292

URL: http://llvm.org/viewvc/llvm-project?rev=269292&view=rev
Log:
[AArch64] Remove command-line option use for testing.

The EXTR combine has been in tree for over 2 years without complain, so go ahead
and remove the option.

Modified:
    llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
    llvm/trunk/test/CodeGen/AArch64/arm64-extract.ll

Modified: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp?rev=269292&r1=269291&r2=269292&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp Thu May 12 08:27:24 2016
@@ -40,12 +40,6 @@ using namespace llvm;
 STATISTIC(NumTailCalls, "Number of tail calls");
 STATISTIC(NumShiftInserts, "Number of vector shift inserts");
 
-// Place holder until extr generation is tested fully.
-static cl::opt<bool>
-EnableAArch64ExtrGeneration("aarch64-extr-generation", cl::Hidden,
-                          cl::desc("Allow AArch64 (or (shift)(shift))->extract"),
-                          cl::init(true));
-
 static cl::opt<bool>
 EnableAArch64SlrGeneration("aarch64-shift-insert-generation", cl::Hidden,
                            cl::desc("Allow AArch64 SLI/SRI formation"),
@@ -7992,8 +7986,6 @@ static SDValue tryCombineToBSL(SDNode *N
 static SDValue performORCombine(SDNode *N, TargetLowering::DAGCombinerInfo &DCI,
                                 const AArch64Subtarget *Subtarget) {
   // Attempt to form an EXTR from (or (shl VAL1, #N), (srl VAL2, #RegWidth-N))
-  if (!EnableAArch64ExtrGeneration)
-    return SDValue();
   SelectionDAG &DAG = DCI.DAG;
   EVT VT = N->getValueType(0);
 

Modified: llvm/trunk/test/CodeGen/AArch64/arm64-extract.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/arm64-extract.ll?rev=269292&r1=269291&r2=269292&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/arm64-extract.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/arm64-extract.ll Thu May 12 08:27:24 2016
@@ -1,4 +1,4 @@
-; RUN: llc -aarch64-extr-generation=true -verify-machineinstrs < %s \
+; RUN: llc -verify-machineinstrs < %s \
 ; RUN: -march=arm64 | FileCheck %s
 
 define i64 @ror_i64(i64 %in) {




More information about the llvm-commits mailing list