[PATCH] D20181: Don't try to rotate a loop more than once - we never do this anyway.

[Michael Zolotukhin via llvm-commits]

mzolotukhin added a comment.

Thanks for taking a look, Sanjoy!

> Is it possible that the new latch, after simplification, ends up being a non-exiting block? If not, might be useful to add an assert(NewLatch is exiting block).


I haven't managed to find such case, but running testsuite with this assertion sounds like a good idea to me. I'll update the patch when the run finishes.

Thanks,
Michael


================
Comment at: lib/Transforms/Scalar/LoopRotation.cpp:572
@@ -571,3 +571,3 @@
 
 /// Rotate \c L as many times as possible. Return true if the loop is rotated
 /// at least once.
----------------
sanjoy wrote:
> Fix comment?
Oops, thanks, will fix!


http://reviews.llvm.org/D20181