[PATCH] D20181: Don't try to rotate a loop more than once - we never do this anyway.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 14:29:23 PDT 2016


sanjoy added a comment.

Is it possible that the new latch, after simplification, ends up being a non-exiting block?  If not, might be useful to add an assert(NewLatch is exiting block).


================
Comment at: lib/Transforms/Scalar/LoopRotation.cpp:572
@@ -571,3 +571,3 @@
 
 /// Rotate \c L as many times as possible. Return true if the loop is rotated
 /// at least once.
----------------
Fix comment?

================
Comment at: lib/Transforms/Scalar/LoopRotation.cpp:585
@@ -585,2 +584,3 @@
 
   // One loop can be rotated multiple times.
+  bool MadeChange =
----------------
Fix comment?


http://reviews.llvm.org/D20181





More information about the llvm-commits mailing list