[PATCH] D19861: Pass LiveIntervals to foldMemoryOperandImpl(), to enable checking of liveness of preg (flag reg).

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Sun May 8 23:41:57 PDT 2016


jonpa updated this revision to Diff 56528.
jonpa added a comment.
Herald added a subscriber: MatzeB.

Other targets methods modified as well.

I realized that LIS may not actually be available (e.g. when called from X86::optimizeLoadInstr()), so I changed the LIS argument into a pointer type with default value of nullptr.

Not sure if there is a better way to assert for single reg unit in SystemZInstrInfo::foldMemoryOperandImpl()?

Not sure if there is / should be a simpler way of checking liveness of a register at the point of an instruction. For example LIS->isRegisterLiveAtInstruction(SystemZ::CC, MI) and LIS->createDeadDefAt(System::CC, MI)?


http://reviews.llvm.org/D19861

Files:
  include/llvm/Target/TargetInstrInfo.h
  lib/CodeGen/InlineSpiller.cpp
  lib/CodeGen/LiveRangeEdit.cpp
  lib/CodeGen/TargetInstrInfo.cpp
  lib/Target/AArch64/AArch64InstrInfo.cpp
  lib/Target/AArch64/AArch64InstrInfo.h
  lib/Target/SystemZ/SystemZInstrInfo.cpp
  lib/Target/SystemZ/SystemZInstrInfo.h
  lib/Target/X86/X86InstrInfo.cpp
  lib/Target/X86/X86InstrInfo.h
  test/CodeGen/SystemZ/int-add-12.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19861.56528.patch
Type: text/x-patch
Size: 13960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160509/0530d6f3/attachment.bin>


More information about the llvm-commits mailing list