[PATCH] D19861: Pass LiveIntervals to foldMemoryOperandImpl(), to enable checking of liveness of preg (flag reg).

[Matthias Braun via llvm-commits]

MatzeB added a comment.

In http://reviews.llvm.org/D19861#421297, @jonpa wrote:

> I did compile it - but only for SystemZ so far. I will fix other targets as well - but let me first await your answer on the overloaded method.. Should that be extended also, you think (see comment)?


Yes please go ahead.


================
Comment at: lib/CodeGen/InlineSpiller.cpp:764-765
@@ -763,4 +763,4 @@
   MachineInstr *FoldMI =
                 LoadMI ? TII.foldMemoryOperand(MI, FoldOps, LoadMI)
-                       : TII.foldMemoryOperand(MI, FoldOps, StackSlot);
+                       : TII.foldMemoryOperand(MI, FoldOps, StackSlot, LIS);
   if (!FoldMI)
----------------
jonpa wrote:
> MatzeB wrote:
> > huh, does this compile with 3 arguments to the first foldMemoryOperand() call?
> Yes - thats a different (overloaded) method. Perhaps this should also be extended with LIS in the same way, for sake of conformity?
Oh that is confusing. We should rename one of them instead of overloading, but that is for a different patch. Yep it sounds sensible to add the extra parameter to both.


http://reviews.llvm.org/D19861