[PATCH] D19861: Pass LiveIntervals to foldMemoryOperandImpl(), to enable checking of liveness of preg (flag reg).

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 09:57:07 PDT 2016


jonpa added a comment.

I did compile it - but only for SystemZ so far. I will fix other targets as well - but let me first await your answer on the overloaded method.. Should that be extended also, you think (see comment)?


================
Comment at: lib/CodeGen/InlineSpiller.cpp:764-765
@@ -763,4 +763,4 @@
   MachineInstr *FoldMI =
                 LoadMI ? TII.foldMemoryOperand(MI, FoldOps, LoadMI)
-                       : TII.foldMemoryOperand(MI, FoldOps, StackSlot);
+                       : TII.foldMemoryOperand(MI, FoldOps, StackSlot, LIS);
   if (!FoldMI)
----------------
MatzeB wrote:
> huh, does this compile with 3 arguments to the first foldMemoryOperand() call?
Yes - thats a different (overloaded) method. Perhaps this should also be extended with LIS in the same way, for sake of conformity?


http://reviews.llvm.org/D19861





More information about the llvm-commits mailing list