[PATCH] D18972: [AMDGPU] Add basic relocation support (currently used for dwarf only)

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 13:37:51 PDT 2016


tstellarAMD added inline comments.

================
Comment at: include/llvm/Support/ELFRelocs/AMDGPU.def:6-9
@@ +5,5 @@
+
+ELF_RELOC(R_AMDGPU_NONE,    0)
+ELF_RELOC(R_AMDGPU_32_LOW,  1)
+ELF_RELOC(R_AMDGPU_32_HIGH, 2)
+ELF_RELOC(R_AMDGPU_64,      3)
----------------
rafael wrote:
> Document what these are.
Could you add the corresponding entries to the VariantKind enum in include/llvm/MC/MCExpr.h too, and also MCSymbolRefExpr::getVariantKindName(VariantKind Kind) in lib/MC/MCExpr.cpp


http://reviews.llvm.org/D18972





More information about the llvm-commits mailing list