[PATCH] D18972: [AMDGPU] Add basic relocation support (currently used for dwarf only)

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: include/llvm/Support/ELFRelocs/AMDGPU.def:6
@@ +5,3 @@
+
+ELF_RELOC(R_AMDGPU_NONE,    0)
+ELF_RELOC(R_AMDGPU_32_LOW,  1)
----------------
Document what these are.

================
Comment at: lib/MC/MCObjectFileInfo.cpp:429-430
@@ +428,4 @@
+  case Triple::amdgcn:
+    LSDAEncoding = dwarf::DW_EH_PE_absptr;
+    PersonalityEncoding = dwarf::DW_EH_PE_absptr;
+    TTypeEncoding = dwarf::DW_EH_PE_absptr;
----------------
Is anything testing this? Can in be in another patch?

================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp:14
@@ -13,2 +13,3 @@
 #include "llvm/MC/MCFixup.h"
+#include "llvm/MC/MCValue.h"
 
----------------
I don't think you have a test for the changes is thin file. Can they be in another patch.


http://reviews.llvm.org/D18972