[PATCH] D19449: Add optimization bisect opt-in calls for ARM passes

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 14:52:48 PDT 2016


rengolin added a comment.

In http://reviews.llvm.org/D19449#411264, @probinson wrote:

> - optnone is something that end-users will do for their own reasons, not as compiler developers; and


Yup.

> - optnone should not be allowed to cause any correctness problems


Yup.

> then I'm okay.  I have no idea about these passes specifically, I just don't want somebody approving a patch based on an incorrect assumption.


To the best of my knowledge, all those passes are optimisations only and should not have been used for anything other than that, either by design or accident. If they did, it's a serious unintentional bug.

Also, this is a simple patch, and if you do find anything on your side, just let us know and this can be easily and quickly reverted, but a bug needs to be created to address the issue.

cheers,
--renato


Repository:
  rL LLVM

http://reviews.llvm.org/D19449





More information about the llvm-commits mailing list