[llvm] r266183 - Don't use misc-unused-parameters check on LLVM.

[Alexander Kornienko via llvm-commits]

There was no discussion, but I don't anticipate any objections, because
this check neither has any support in
http://llvm.org/docs/CodingStandards.html nor corresponds to a wide-spread
practice in the LLVM code. There are a handful of methods using this
convention and hundreds that don't. This is the single most noisy check on
LLVM code that was turned on before this commit. If we want to use this
check, we first need to adopt the corresponding rule and clean up thousands
of warnings from this check.
On Apr 13, 2016 19:32, "David Blaikie" <dblaikie at gmail.com> wrote:

> Was there a thread/discussion/context for this choice?
>
> On Wed, Apr 13, 2016 at 1:58 AM, Alexander Kornienko via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: alexfh
>> Date: Wed Apr 13 03:58:52 2016
>> New Revision: 266183
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=266183&view=rev
>> Log:
>> Don't use misc-unused-parameters check on LLVM.
>>
>> Modified:
>>     llvm/trunk/.clang-tidy
>>
>> Modified: llvm/trunk/.clang-tidy
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/.clang-tidy?rev=266183&r1=266182&r2=266183&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/.clang-tidy (original)
>> +++ llvm/trunk/.clang-tidy Wed Apr 13 03:58:52 2016
>> @@ -1,4 +1,4 @@
>> -Checks:
>> '-*,clang-diagnostic-*,llvm-*,misc-*,readability-identifier-naming'
>> +Checks:
>> '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
>>  CheckOptions:
>>    - key:             readability-identifier-naming.ClassCase
>>      value:           CamelCase
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160414/b9b82de3/attachment.html>