<div dir="ltr"><p dir="ltr">There was no discussion, but I don't anticipate any objections, because this check neither has any support in <a href="http://llvm.org/docs/CodingStandards.html">http://llvm.org/docs/CodingStandards.html</a> nor corresponds to a wide-spread practice in the LLVM code. There are a handful of methods using this convention and hundreds that don't. This is the single most noisy check on LLVM code that was turned on before this commit. If we want to use this check, we first need to adopt the corresponding rule and clean up thousands of warnings from this check.</p>
<div class="gmail_quote">On Apr 13, 2016 19:32, "David Blaikie" <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Was there a thread/discussion/context for this choice?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 13, 2016 at 1:58 AM, Alexander Kornienko via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: alexfh<br>
Date: Wed Apr 13 03:58:52 2016<br>
New Revision: 266183<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=266183&view=rev" rel="noreferrer">http://llvm.org/viewvc/llvm-project?rev=266183&view=rev</a><br>
Log:<br>
Don't use misc-unused-parameters check on LLVM.<br>
<br>
Modified:<br>
    llvm/trunk/.clang-tidy<br>
<br>
Modified: llvm/trunk/.clang-tidy<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/.clang-tidy?rev=266183&r1=266182&r2=266183&view=diff" rel="noreferrer">http://llvm.org/viewvc/llvm-project/llvm/trunk/.clang-tidy?rev=266183&r1=266182&r2=266183&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/.clang-tidy (original)<br>
+++ llvm/trunk/.clang-tidy Wed Apr 13 03:58:52 2016<br>
@@ -1,4 +1,4 @@<br>
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,readability-identifier-naming'<br>
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'<br>
 CheckOptions:<br>
   - key:             readability-identifier-naming.ClassCase<br>
     value:           CamelCase<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div>
</div>