[PATCH] D18200: Add __atomic_* lowering to AtomicExpandPass.

[JF Bastien via llvm-commits]

Looks like this broke the build:

/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘void
{anonymous}::AtomicExpand::expandAtomicLoadToLibcall(llvm::LoadInst*)’:
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1000:8: warning: unused
variable ‘expanded’ [-Wunused-variable]
   bool expanded = expandAtomicOpToLibcall(
        ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘void
{anonymous}::AtomicExpand::expandAtomicStoreToLibcall(llvm::StoreInst*)’:
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1013:8: warning: unused
variable ‘expanded’ [-Wunused-variable]
   bool expanded = expandAtomicOpToLibcall(
        ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘void
{anonymous}::AtomicExpand::expandAtomicCASToLibcall(llvm::AtomicCmpXchgInst*)’:
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1027:8: warning: unused
variable ‘expanded’ [-Wunused-variable]
   bool expanded = expandAtomicOpToLibcall(
        ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In function
‘llvm::ArrayRef<llvm::RTLIB::Libcall>
GetRMWLibcall(llvm::AtomicRMWInst::BinOp)’:
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1068:12: error: could not
convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsXchg)’ from ‘const
llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’
     return LibcallsXchg;
            ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1070:12: error: could not
convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsAdd)’ from ‘const
llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’
     return LibcallsAdd;
            ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1072:12: error: could not
convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsSub)’ from ‘const
llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’
     return LibcallsSub;
            ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1074:12: error: could not
convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsAnd)’ from ‘const
llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’
     return LibcallsAnd;
            ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1076:12: error: could not
convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsOr)’ from ‘const
llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’
     return LibcallsOr;
            ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1078:12: error: could not
convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsXor)’ from ‘const
llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’
     return LibcallsXor;
            ^
/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1080:12: error: could not
convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsNand)’ from ‘const
llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’
     return LibcallsNand;
            ^



On Mon, Apr 11, 2016 at 3:28 PM, James Y Knight <jyknight at google.com> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL266002: Add __atomic_* lowering to AtomicExpandPass.
> (authored by jyknight).
>
> Changed prior to commit:
>   http://reviews.llvm.org/D18200?vs=52724&id=53332#toc
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18200
>
> Files:
>   llvm/trunk/docs/Atomics.rst
>   llvm/trunk/include/llvm/CodeGen/RuntimeLibcalls.h
>   llvm/trunk/include/llvm/Target/TargetLowering.h
>   llvm/trunk/lib/CodeGen/AtomicExpandPass.cpp
>   llvm/trunk/lib/CodeGen/TargetLoweringBase.cpp
>   llvm/trunk/lib/Target/Sparc/SparcISelLowering.cpp
>   llvm/trunk/test/Transforms/AtomicExpand/SPARC/libcalls.ll
>   llvm/trunk/test/Transforms/AtomicExpand/SPARC/lit.local.cfg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160411/1e3c71a7/attachment.html>