<div dir="ltr">Looks like this broke the build:<blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘void {anonymous}::AtomicExpand::expandAtomicLoadToLibcall(llvm::LoadInst*)’:</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1000:8: warning: unused variable ‘expanded’ [-Wunused-variable]</font></div></div><div><div><font face="monospace, monospace"> bool expanded = expandAtomicOpToLibcall(</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘void {anonymous}::AtomicExpand::expandAtomicStoreToLibcall(llvm::StoreInst*)’:</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1013:8: warning: unused variable ‘expanded’ [-Wunused-variable]</font></div></div><div><div><font face="monospace, monospace"> bool expanded = expandAtomicOpToLibcall(</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘void {anonymous}::AtomicExpand::expandAtomicCASToLibcall(llvm::AtomicCmpXchgInst*)’:</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1027:8: warning: unused variable ‘expanded’ [-Wunused-variable]</font></div></div><div><div><font face="monospace, monospace"> bool expanded = expandAtomicOpToLibcall(</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp: In function ‘llvm::ArrayRef<llvm::RTLIB::Libcall> GetRMWLibcall(llvm::AtomicRMWInst::BinOp)’:</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1068:12: error: could not convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsXchg)’ from ‘const llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’</font></div></div><div><div><font face="monospace, monospace"> return LibcallsXchg;</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1070:12: error: could not convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsAdd)’ from ‘const llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’</font></div></div><div><div><font face="monospace, monospace"> return LibcallsAdd;</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1072:12: error: could not convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsSub)’ from ‘const llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’</font></div></div><div><div><font face="monospace, monospace"> return LibcallsSub;</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1074:12: error: could not convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsAnd)’ from ‘const llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’</font></div></div><div><div><font face="monospace, monospace"> return LibcallsAnd;</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1076:12: error: could not convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsOr)’ from ‘const llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’</font></div></div><div><div><font face="monospace, monospace"> return LibcallsOr;</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1078:12: error: could not convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsXor)’ from ‘const llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’</font></div></div><div><div><font face="monospace, monospace"> return LibcallsXor;</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div><div><div><font face="monospace, monospace">/s/llvm/llvm/lib/CodeGen/AtomicExpandPass.cpp:1080:12: error: could not convert ‘(const llvm::RTLIB::Libcall*)(& LibcallsNand)’ from ‘const llvm::RTLIB::Libcall*’ to ‘llvm::ArrayRef<llvm::RTLIB::Libcall>’</font></div></div><div><div><font face="monospace, monospace"> return LibcallsNand;</font></div></div><div><div><font face="monospace, monospace"> ^</font></div></div></blockquote><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 11, 2016 at 3:28 PM, James Y Knight <span dir="ltr"><<a href="mailto:jyknight@google.com" target="_blank">jyknight@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL266002: Add __atomic_* lowering to AtomicExpandPass. (authored by jyknight).<br>
<br>
Changed prior to commit:<br>
<a href="http://reviews.llvm.org/D18200?vs=52724&id=53332#toc" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18200?vs=52724&id=53332#toc</a><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D18200" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18200</a><br>
<br>
Files:<br>
llvm/trunk/docs/Atomics.rst<br>
llvm/trunk/include/llvm/CodeGen/RuntimeLibcalls.h<br>
llvm/trunk/include/llvm/Target/TargetLowering.h<br>
llvm/trunk/lib/CodeGen/AtomicExpandPass.cpp<br>
llvm/trunk/lib/CodeGen/TargetLoweringBase.cpp<br>
llvm/trunk/lib/Target/Sparc/SparcISelLowering.cpp<br>
llvm/trunk/test/Transforms/AtomicExpand/SPARC/libcalls.ll<br>
llvm/trunk/test/Transforms/AtomicExpand/SPARC/lit.local.cfg<br>
<br>
</blockquote></div><br></div>