[PATCH] D18911: ELF: Emit .eh_frame_hdr entries for FDEs with duplicate PCs.

[Rafael Espíndola via llvm-commits]

On Apr 8, 2016 10:43 PM, "Peter Collingbourne" <peter at pcc.me.uk> wrote:
>
> pcc added a comment.
>
> It seems feasible, I'll see if I can do it. In the meantime, this fixes
the issue with backtrace(), and also matches gold's behavior, so maybe we
can land this as a first step with a FIXME.

Please don't. Just subtracting one each time from fde_count should be easy.

Matching gold's behavior sounds like just cargo cult in this case.

> I was also thinking about cases where the unwind info for functions with
identical bodies was semantically different. For example, I suppose you
might be able to have functions with identical bodies but different
personality functions. If that's possible, I suppose we may need to inhibit
ICF in such cases and do something completely different here.
>

If you avoid ICF you would not need to do anything in here, no?

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160409/060ce495/attachment.html>