[PATCH] D18901: ARM: Use a callee save register for the swiftself parameter.

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: lib/Target/ARM/ARMFrameLowering.cpp:914
@@ -925,1 +913,3 @@
+      bool isLiveIn = MF.getRegInfo().isLiveIn(Reg);
+      if (!isLiveIn)
         MBB.addLiveIn(Reg);
----------------
rengolin wrote:
> yeah, I meant it as a duplication. :)
looks good

================
Comment at: test/CodeGen/ARM/swiftself.ll:2
@@ -3,1 +1,3 @@
+; RUN: llc -verify-machineinstrs -mtriple=armv7k-apple-ios8.0 -mcpu=cortex-a7 -o - %s | FileCheck --check-prefix=CHECK --check-prefix=OPT %s
+; RUN: llc -O0 -verify-machineinstrs -mtriple=armv7k-apple-ios8.0 -mcpu=cortex-a7 -o - %s | FileCheck %s
 
----------------
MatzeB wrote:
> rengolin wrote:
> > The CHECK prefix is still there... already assumed by default.
> ```
> static void AddCheckPrefixIfNeeded() {
>   if (CheckPrefixes.empty())
>     CheckPrefixes.push_back("CHECK");
> }
> ```
> It is only default if you do not add any other check-prefixes.
Hum, you're right... I assumed it always did... :(


Repository:
  rL LLVM

http://reviews.llvm.org/D18901